Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analytics: user-defined analytics #44

Closed
humitos opened this issue Apr 12, 2023 · 1 comment
Closed

Analytics: user-defined analytics #44

humitos opened this issue Apr 12, 2023 · 1 comment

Comments

@humitos
Copy link
Member

humitos commented Apr 12, 2023 •
edited
Loading

Do we want to keep support for this? Right now, when the user defined the Project.analytics_code we inject Google Analytics on their documentation pages. IMO, we should stop doing this "automagically" and it should be the user the ones that integrate these analytics by themselves.

I removed the user-defined analytics in 8d1855c. We can revert if we consider this a useful feature, tho.
humitos added a commit that referenced this issue Apr 12, 2023
@humitos
Analytics: remove user-defined analytics for now
8d1855c 
I'm removing user-defined analytics for now because I think we should not
support this in the new client. Users should be able to configure the analytics
they want by their own following the instructions of the doctool they are using.

See #44
@humitos
Copy link
Member Author

humitos commented Apr 13, 2023

We are not integrating Google Analytics into the new client. See readthedocs/readthedocs.org#9530. I'm closing this issue.

@humitos humitos closed this as completed Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@humitos