Search: small updates on look & feel #497
Conversation
Based on my feedback from #496
humitos
changed the title
|
Those are some great updates! One thing to be careful of is AA, the text color looks like it doesn't have enough contract with the background. You can check this in Firefox with right clicking the element and "Inspect Accessibility properties". |
| width: 60%; | ||
| max-height: 1000px; | ||
| max-width: 1500px; | ||
| max-width: 700px; |
There was a problem hiding this comment.
What do these position changes look like on mobile?
There was a problem hiding this comment.
Very thin. That's a known issue that we are tracking in #423. I won't touch that in this PR.
There was a problem hiding this comment.
This might be best as a relative unit either way, em or vw instead of px. A change in font size will make this look too spaced out (smaller font size) or too cramped (larger font size).
|
Cool, I reviewed and updated the colors to follow the standards. This PR is ready for re-review and merge. |
Based on my feedback from #496
This is the results. I think it looks a lot better, more compacted and easy to quickly scan.
Closes #496