Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit date #221

Merged
merged 6 commits into from
Jun 6, 2023
Merged

Add explicit date #221

merged 6 commits into from
Jun 6, 2023

Conversation

ericholscher
Copy link
Member

No description provided.

@ericholscher ericholscher requested a review from a team as a code owner May 31, 2023 15:57
@ericholscher ericholscher requested a review from benjaoming May 31, 2023 15:57
Copy link
Contributor

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to have the date visible quickly, I'm fine about merging this and adding other dates in a second iteration.

But if someone adds the brownout dates (+ nice with a definition of what we mean by that) in this PR, that's great, too 👍

migrate-configuration-v2.rst Outdated Show resolved Hide resolved
migrate-configuration-v2.rst Outdated Show resolved Hide resolved
migrate-configuration-v2.rst Outdated Show resolved Hide resolved
Comment on lines 37 to 38
* **Monday, July 24, 2023**: Do the first brownout (temporarily enforce this deprecation) for 2 hours in 3 timezones, 9:00-11:00, in 3 timezones: UTC-8, UTC, and UTC+8.
* **Monday, August 7, 2023**: Do a second brownout (temporarily enforce this deprecation) for 2 hours in 3 timezones, 9:00-11:00, in 3 timezones: UTC-8, UTC, and UTC+8.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brought up in comments here, but maybe lets make this even easier on us and replicate what GitHub did: 12h window first date, 24h window the second date. I'm guessing it might be hard to have folks around for all of these 2h windows, thinking about this a bit more. We'll definitely catch more projects this way too.

Copy link
Contributor

@agjohnson agjohnson Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we start a 12h window Mon July 24 @ 0:00 PT and go till 12:00 PT, this is what the overlap looks like:

(I used the wrong date for some reason, but timing stands)

image

Asia users will get errors starting at the end of their day and the errors will resolve overnight, so not great, but we have more users in EU/US anyways.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me 👍

@agjohnson
Copy link
Contributor

Note, before merging this, urllib3 might not be planning to add a deprecation exception like we saw in urllib3 2.0. This would allow us to relax the timeframe a little bit, and maybe aim for end of Sept instead. Still waiting on confirmation here, in #222

@agjohnson
Copy link
Contributor

Confirmed that urllib3 will not add a deprecation exception like urllib3 2.0 did. Because of this we will not have to worry about builds failing due to outdated libssl come Sept 11.

So, we can now set a date later in Sept (or even call it the first week of Oct) to give a bit more room for this migration timeframe.

We also don't need to be strict about the deprecation date now either. If projects aren't migrating over, we had talked about allowing some projects to continue building after the cutoff (big or long standing projects having trouble with the migration).

@ericholscher
Copy link
Member Author

ericholscher commented Jun 5, 2023

@agjohnson I'd like to move forward here, so just want to get some dates announced. I guess I don't understand the reasoning for changing the dates we agreed to on the call? Is there a specific worry you're trying to address?

@agjohnson
Copy link
Contributor

Just gaining 3 weeks on our timeframe. We described the timeframe as fairly tight. We could rather quickly decide on Monday Sept 25 and keep everything else the same.

@ericholscher
Copy link
Member Author

I'm fine with that date, and gives us room for a 3rd brownout if we need it.

@agjohnson
Copy link
Contributor

That's a great idea. We could add another 24h or even 48h brownout on Sept 4 in place of the cutover.

Looks like everyone is planning on being around Mon Sept 25 too, just in case. We will have been through this 3 times at that point though, so I doubt there will be many fires then.

Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three changes:

  • Bump brownout Aug 7 -> Aug 14 to evenly space
  • Sep 4 brownout for 48h added. If 24h seems more right, lets go with that though.
  • Bump out cutoff date

migrate-configuration-v2.rst Outdated Show resolved Hide resolved
migrate-configuration-v2.rst Outdated Show resolved Hide resolved
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me with Anthony's suggestions 👍

@ericholscher ericholscher enabled auto-merge (squash) June 6, 2023 16:31
@ericholscher ericholscher merged commit 6898bf8 into main Jun 6, 2023
@ericholscher ericholscher deleted the add-date branch June 6, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants