Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commit hash to build table #5

Closed
reece opened this issue Apr 3, 2017 · 4 comments
Closed

Add commit hash to build table #5

reece opened this issue Apr 3, 2017 · 4 comments
Labels
Accepted Accepted issue on our roadmap Feature New feature

Comments

@reece
Copy link

reece commented Apr 3, 2017

It would be very handy for the "Recent Builds" table to indicate the commit hash (or changeset id for hg, etc). Even better would be a link to the commit and the first line of the commit message.

@stsewd
Copy link
Member

stsewd commented Jan 5, 2018

Adding all the hash would be a little long, for git we can truncate to 7 characters and add a link to the repo.
I don't know how this works with the others vcs.

@reece
Copy link
Author

reece commented Jan 5, 2018

I agree the full hash is long and unnecessary. 7 prefix chars is fine. The point is to be able to link to a specific changeset. Thanks!

(And Mercurial will also accept prefixes of the revision hash)

@humitos humitos changed the title Feature request: Add commit hash to build table Add commit hash to build table Aug 25, 2019
@agjohnson agjohnson transferred this issue from readthedocs/readthedocs.org May 20, 2020
@agjohnson
Copy link
Contributor

I've added this in some previous pile of commits. The truncated commit will show in the build list now, though we have a few more things to handle:

  • What does svn look like? We could also special case git/mercurial repositories and skip this for svn
  • Are there cases that the commit is something other than a rev hash? For instance, can the template display a tag or something else that we shouldn't truncate?

@agjohnson agjohnson added Accepted Accepted issue on our roadmap Feature New feature labels Nov 19, 2021
@agjohnson agjohnson added this to the Public beta - community milestone Nov 19, 2021
@agjohnson
Copy link
Contributor

This has been a feature for a while on our beta dashboard:

https://beta.readthedocs.org/projects/time-test/builds/23581428/

image

This does respect tags as well, but likely falls down a bit on SVN and friends. I don't feel we need to design around these anymore as we are announcing deprecation for support on these tools with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Feature New feature
Projects
None yet
Development

No branches or pull requests

3 participants