Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project import: "Edit Advanced Options" #10392

Closed
benjaoming opened this issue Jun 6, 2023 · 2 comments · Fixed by #10603
Closed

Project import: "Edit Advanced Options" #10392

benjaoming opened this issue Jun 6, 2023 · 2 comments · Fixed by #10603
Assignees
Labels
Accepted Accepted issue on our roadmap Design Design or UX/UI related Needed: design decision A core team decision is required

Comments

@benjaoming
Copy link
Contributor

benjaoming commented Jun 6, 2023

In #10356, we added a new step about the configuration file. It prompts the user to add a .readthedocs.yaml configuration file before continuing.

This means that "Edit Advanced Options" in the previous step is dangling a bit. I think that adding a configuration step takes the users focus away from their previous "Edit Advanced Options" choice.

image

I think there are 2 possible choices here:

  1. Move the checkbox option to the configuration step.

  2. Remove it entirely 💯 After adding a configuration file, the most important thing for all users is to see that a build is running and get a failure/warning when a .readthedocs.yaml wasn't found or is invalid. Also, the previous use case of visiting "Advanced Options" largely does the same as what the config file offers!

CC: @agjohnson @humitos

Related: #10342

@benjaoming benjaoming added Design Design or UX/UI related Needed: design decision A core team decision is required labels Jun 6, 2023
@humitos
Copy link
Member

humitos commented Jun 14, 2023

Note that the "Advanced options" are completely useless actually:

Screenshot_2023-06-14_11-50-31

I'd vote to completely remove this step and move the "language" field to the initial step, which is the only important one (tied to the URL of the project). Those other "Extra details" (as the title says), should be found by the user later, not at import time, IMO.

@benjaoming
Copy link
Contributor Author

I'd vote to completely remove this step and move the "language" field to the initial step

It's a great idea to let the user choose the language in the initial import step. Is the step you mean?

I 💯 agree that we should completely remove the "Edit advanced project options" checkbox.

@benjaoming benjaoming added the Accepted Accepted issue on our roadmap label Jun 14, 2023
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Jun 14, 2023
@humitos humitos self-assigned this Aug 1, 2023
@humitos humitos moved this from Planned to Needs review in 📍Roadmap Aug 6, 2023
humitos added a commit that referenced this issue Aug 6, 2023
This commit removes the "Extra/Advanced" step and moves the "language" attribute
to the "Basics" step -- the first one, since that field is important.

Closes #10392
@github-project-automation github-project-automation bot moved this from Needs review to Done in 📍Roadmap Aug 18, 2023
humitos added a commit that referenced this issue Aug 18, 2023
* Import: remove extra/advanced step from project import wizard

This commit removes the "Extra/Advanced" step and moves the "language" attribute
to the "Basics" step -- the first one, since that field is important.

Closes #10392

* Update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Design Design or UX/UI related Needed: design decision A core team decision is required
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants