Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping based on PR labels to prevent hitting the rate limit #11326

Open
achimnol opened this issue May 15, 2024 · 5 comments
Open

Skipping based on PR labels to prevent hitting the rate limit #11326

achimnol opened this issue May 15, 2024 · 5 comments
Labels
Feature New feature Needed: design decision A core team decision is required

Comments

@achimnol
Copy link

achimnol commented May 15, 2024

What's the problem this feature will solve?

Since #9649, we can now skip the rest of a build job using special exit codes like 183.
However, it still occupies the rate limit as the build job needs to be started anyway as the skip decision is made inside the build script.

Describe the solution you'd like

I'd like to have a fast-path for skipping builds using metadata like GitHub PR's labels (e.g., continue or skip if a specific label exists / continue or skip if a specific label does not exist), before starting the build job, without occupying the rate limit.

@humitos humitos added Feature New feature Needed: design decision A core team decision is required labels May 16, 2024
@humitos
Copy link
Member

humitos commented May 16, 2024

Hi @achimnol! Thanks for your feature suggestion. We will discuss about it and see if we can find a place in our roadmap to prioritize this work.

Are you hitting the rate limit too frequently due to this issue? Would you please share what's the project URL where you are hitting this?

@achimnol
Copy link
Author

achimnol commented May 16, 2024

It’s https://github.com/lablup/backend.ai . We have recently adopted https://graphite.dev and an automated backport PR generator, and now see increased rate of PR creation and updates. This makes it to hit the RTD build rate limit constantly, although most of builds are skipped.

@humitos
Copy link
Member

humitos commented May 16, 2024

Can you post the URL of the Read the Docs project?

@achimnol
Copy link
Author

https://readthedocs.org/projects/sorna/
and
https://readthedocs.org/projects/sorna-ko

@achimnol
Copy link
Author

image

We are observing that too many PR checks are pending due to the concurrency limit, while most of the jobs will be skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

2 participants