-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to use environment variable ? #11755
Comments
Hi, I see that build is from a PR, you probably need to mark your env var as public, see https://docs.readthedocs.io/en/stable/environment-variables.html#environment-variables-and-build-process. |
arf that's unexpected, I though privates meant the same as in github, i.e. "you cannot see it". So it means that if I build this specific branch manually it's going to work right ? |
Hi I worked on my little experiment (https://app.readthedocs.org/projects/geetools/builds/26250084/). If I build the branch itself I can use the private variables. Why do you prevent use of private env variables in the PR builds ? |
Anyone can open a PR on GitHub, they can change the commands to steal the environment variable. |
This could be mentioned in the docs, to give more context to users and avoid this confusion. |
But you can also prevent the CI to start (and I think it's the default behaviour) if not validated by a maintainer right ? In my repositories when a new developer creates a PR I need to accept to launch the workflows before they run and as a contributors in many packages I also faced it myself, waiting for someone to validate my PR before anything is run. isn't the triggering mechanism (from GitHub) of RDT subject to the same constraints ? |
Details
Expected Result
I would like to use environment variable in my build:
I run the following code in my
conf.py
:I would expect to see the process
pytest_gee.init_ee_from_service_account()
to start as it's listed in my environment variable but I get the following error instead meaning the value is not accecible from the build env.I build the environment from scratch with the configuration file. should I add the env variable manually as in GitHub actions ?
The text was updated successfully, but these errors were encountered: