Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version: better support for manual created latest and stable versions #11823

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Dec 4, 2024

Closes #11773

@stsewd stsewd requested a review from a team as a code owner December 4, 2024 18:38
@stsewd stsewd requested a review from humitos December 4, 2024 18:38
readthedocs/builds/models.py Outdated Show resolved Hide resolved
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow this change completely; but I think I don't fully understand the underlying issue either 🤷🏼 . I did a review, but I don't feel comfortable approving it because I'm confused. I will ask @ericholscher for a review here as well 😄

readthedocs/builds/models.py Show resolved Hide resolved
readthedocs/builds/models.py Outdated Show resolved Hide resolved
@humitos humitos requested a review from ericholscher December 5, 2024 11:13
@stsewd
Copy link
Member Author

stsewd commented Dec 5, 2024

@humitos we have two types of latest and stable versions, the ones managed by rtd (machine=True) that basically are aliases, and the ones that the user manually creates (a tag/branch named latest/stable), in that case the branch/tag isn't an alias, but the branch/tag itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent resolution of 'stable' branch in popup windows
2 participants