Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring the preview GH action into the product #11780

Open
humitos opened this issue Nov 19, 2024 · 1 comment
Open

Bring the preview GH action into the product #11780

humitos opened this issue Nov 19, 2024 · 1 comment
Labels
Feature New feature Needed: design decision A core team decision is required

Comments

@humitos
Copy link
Member

humitos commented Nov 19, 2024

We discussed about migrating the preview GH action into the product itself. The user should be able to mark Add link to preview in the pull request with comment and description as options.

I think we will need to use use the SocialAccount from one of the owners to put the link in the pull request as a comment or editing the description because we don't have a GitHub App for Read the Docs. We will need to research a little more here.

Note there are reason why most of these bots use a new comment, so we should probably use that approach only. Example, the content added to the description ends up in the commit message --which is something we don't want.

Sentry comment's example: #11765 (comment)

@humitos humitos added the Feature New feature label Nov 19, 2024
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Nov 19, 2024
@agjohnson agjohnson added the Needed: design decision A core team decision is required label Dec 3, 2024
@agjohnson
Copy link
Contributor

This would be good to start to figure out. Some things to explore:

  • Is GHA required?
  • Can we use a GHA in addition to our normal Oauth application, not changing authentication/authorization on our side yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature Needed: design decision A core team decision is required
Projects
Status: Planned
Development

No branches or pull requests

2 participants