Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authentication documentation #11834

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add authentication documentation #11834

wants to merge 2 commits into from

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Dec 10, 2024

This adds two pages:

  • A intro reference page on authentication methods
  • A guide on managing maintainers for Community

These are just basic places to start on this content.
I wasn't 100% sure the best way to structure the Authencation methods page,
so definitely would like feedback on that one.

Fixes #11835


📚 Documentation previews 📚

This adds two pages:

* A intro reference page on authentication methods
* A guide on managing maintainers for Community

These are just basic places to start on this content.
I wasn't 100% sure the best way to structure the Authencation methods page,
so definitely would like feedback on that one.
@ericholscher ericholscher requested a review from a team as a code owner December 10, 2024 00:21
@@ -38,3 +41,4 @@ How-to guides: security and access
Manually importing private repositories </guides/importing-private-repositories>
Using private Git submodules </guides/private-submodules>
Installing private python packages </guides/private-python-packages>
Manage Maintainers </guides/managing-maintainers>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Manage Maintainers </guides/managing-maintainers>
Manage maintainers </guides/managing-maintainers>


* Navigate to the :guilabel:`Settings` tab of your project.
* Click on the :guilabel:`Setup > Maintainers` tab.
* Click the :guilabel:`Add Maintainer` button.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Click the :guilabel:`Add Maintainer` button.
* Click the :guilabel:`Add maintainer` button.

Follow these steps:

* Navigate to the :guilabel:`Settings` tab of your project.
* Click on the :guilabel:`Setup > Maintainers` tab.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forget what pattern we were using for multiple UI steps in a GUI label but explicit sounds clearer anyways:

Suggested change
* Click on the :guilabel:`Setup > Maintainers` tab.
* Under :guilabel:`Setup`, click on the :guilabel:`Maintainers` tab.

Comment on lines +4 to +5
|org_brand| allows you to manage maintainers for your projects.
Maintainers have admin access to the project, so be careful when adding them.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe to just to help make it really clear how this is different from business:

Suggested change
|org_brand| allows you to manage maintainers for your projects.
Maintainers have admin access to the project, so be careful when adding them.
|org_brand| allows you to manage maintainers for your projects.
Every project is configured with its own list of maintainers
who will all have admin privileges to the project,
so be careful when adding new maintainers.

Follow these steps:

* Navigate to the :guilabel:`Settings` tab of your project.
* Click on the :guilabel:`Setup > Maintainers` tab.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above here

Comment on lines +27 to +28
* Automatic repository syncing for easy project import
* Automatic webhook creation on project import
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Automatic repository syncing for easy project import
* Automatic webhook creation on project import
* Automatic repository syncing for easy project creation
* Automatic webhook creation on project creation

Comment on lines +64 to +65
This means that you can login to Read the Docs with this method,
but we aren't able to determine which projects you have access to automatically.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This means that you can login to Read the Docs with this method,
but we aren't able to determine which projects you have access to automatically.
This means that users can login to Read the Docs with this method,
but we aren't able to determine which projects each user has access to automatically.

:ref:`sso_saml`
Learn how to configure SAML authentication for your organization.

Two factor authentication
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Two factor authentication
Two-factor authentication

Two factor authentication
-------------------------

Read the Docs supports Two Factor Authentication (2FA) for added security on all authentication methods.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Read the Docs supports Two Factor Authentication (2FA) for added security on all authentication methods.
Read the Docs supports two-factor authentication (2FA) for added security on all authentication methods.

.. seealso::

:doc:`/guides/management/2fa`
Learn how to enable and disable Two Factor Authentication on your account.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Learn how to enable and disable Two Factor Authentication on your account.
Learn how to enable and disable two-factor authentication on your account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Auth section to docs
2 participants