-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop creating a conf.py/mkdocs.yaml file automatically for users and doing magic #2483
Comments
We could create a redirect for all projects? Also, for mkdocs projects, this is already done in the mkdocs side #1615 (comment) For sphinx there isn't a configuration or an extension (I just did a simple google search). I guess we could write this in the rtd-extension, or just deal with this creating an index file. Why? Because people can even create docs without a README file, and hit the 404 issue. |
Updated this issue to be about removing the magic around README handling. |
If I understood correctly we need to remove this part of the code: we will not support README to index creation anymore ? and for which will generate a |
I will let others chime in as well, but I am in favor 👍 of removing this. In general, I believe that Read the Docs should not make broken projects build that are unable to be built outside of Read the Docs. This will lead to more predictable builds. |
This value has been the default since the start of the project https://github.com/mkdocs/mkdocs/blob/0.13.0/mkdocs/config/defaults.py#L44 We should respect that default value, (we should actually don't edit it at all #2483). So, instead of trying to guess the docs dir always, only try to guess it if the user doesn't have mkdocs.yaml file. This should avoid any backwards compatibility and avoid weird bugs to new users. Closes #7539
This value has been the default since the start of the project https://github.com/mkdocs/mkdocs/blob/0.13.0/mkdocs/config/defaults.py#L44 We should respect that default value, (we should actually don't edit it at all #2483). So, instead of trying to guess the docs dir always, only try to guess it if the user doesn't have mkdocs.yaml file. This should avoid any backwards compatibility and avoid weird bugs to new users. Closes #7539
It is my understanding that this is not a "Good First Issue"? |
yeah, this is going to be handled when we have the new builders in place. |
There is a bunch of history here and lot of issues linked to this issue plus others that talk about probably the same thing. So, I'm doing a small summary of what we are doing here:
|
I sent the email to these users today 📧 🚀 . We set August 28th for the feature removal. |
) * Post: doctools without configuration file deprecation announcement Follows readthedocs/readthedocs.org#2483 * Adding the updated content from the HackMD. * Fix RST * Fix link --------- Co-authored-by: Eric Holscher <[email protected]>
We should stop adding a
conf.py
file for projects that don't have one. We also used to do magic around README handling, we should remove it:https://github.com/rtfd/readthedocs.org/blob/535f31540fea36a321d148cfee302b34e90adfc9/readthedocs/doc_builder/base.py#L97-L116
The text was updated successfully, but these errors were encountered: