Feature flag: remove unused ones #10423
Conversation
We can safely remove this feature flag since it's marked as `default_true=True` and `future_default_true=True` in both platforms. This means that it applies to all the projects.
It was a failed attempt to make Sphinx to run fast.
It became a Django setting and it's integrated in the application now.
It's enabled by default to all the projects and it has been working fine.
This was an attempt to show debugging information. This can be achieved now with `build.jobs` in case the user want to display this data. Internally, we are storing some of this data in BuildData from `telemetry` database.
We have been using this by default in all projects.
We have been using this for a long time and we are happy.
We removed this code completely and we are not doing this anymore.
It's not used. Only leftovers.
Only used by 1 projects. Its last build was 2 years ago.
We have been using this by default to everybody for months now and it's working fine. It's safe to remove.
|
This is super nice!! The shear amount of feature flags is pretty uphill to look at as someone trying to understand how things work.
|
There was a problem hiding this comment.
Yes, it was tricky to review :) Some Feature flags were always on and some feature flags were always off... so when the flag is removed, we have to check that conditionals are restored with the correct assumption :)
I looked at the checks and they seem like Prospector bugs. I think we should be safe and that Prospector and several test cases would fail if an unreferenced feature flag was left.
Tests need to be updated. But once they work, everything should be fine 👍
|
I updated this PR to fix all the tests and remove the leftovers that I found. I the tests pass, we can merge it. |
…mitos/remove-old-feature-flags
|
Have you seen the current test errors (network errors) in other PRs? I don't think that I've seen it recently, so just wondering that i could be something related to these changes. |
|
Yeah, it was a missing mock. |
Follows what's described in #9779.
This initial PR only removes feature flags that are not used at all, or are enabled by default to all the projects. Note that each commit removes one and only one feature flag. This could be useful while reviewing.
Once we merge this PR, we we have to remove all the
Featurerows from the db to avoid future confusions as I had to deal with today 😄Next iteration will remove more feature flags that require communication to users or some internal discussion.