Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: remove PyPy support #10514

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Build: remove PyPy support #10514

merged 1 commit into from
Jul 10, 2023

Conversation

humitos
Copy link
Member

@humitos humitos commented Jul 6, 2023

We introduced PyPy support as an alternative way to make Sphinx builds faster in #3870

We enabled it in some projects and we tried to communicate this to some CPU intense projects. However, nobody kept using it after doing some experiments with it.

I checked our logs and Telemetry data and I found 0 projects using pypy in their builds. So, I'm happy to remove its support and simplify our product as its maintainance as well.

Even the PyPy project is not using it when building their own documentation: https://readthedocs.org/projects/pypy/builds/21201174/


📚 Documentation previews 📚

We introduced PyPy support as an alternative way to make Sphinx builds faster in
#3870

We enabled it in some projects and we tried to communicate this to some CPU
intense projects. However, nobody kept using it after doing some experiments
with it.

I checked our logs and Telemetry data and I found 0 projects using `pypy` in
their builds. So, I'm happy to remove its support and simplify our product as
its maintainance as well.

Even the PyPy project is not using it when building their own documentation:
https://readthedocs.org/projects/pypy/builds/21201174/
@humitos humitos requested review from a team as code owners July 6, 2023 09:41
@humitos humitos requested a review from ericholscher July 6, 2023 09:41
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this if it doesn't break anything, but I'm a little surprised nobody is using this. It makes me think the query we did was broken, as I don't know if there's any feature we've shipped for a while that nobody is using, but perhaps this is the one!

Comment on lines -331 to -333
- ``pypy3.7``
- ``pypy3.8``
- ``pypy3.9``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think it makes sense more as an option for builds.tools, but I'm pretty surprised nobody is using this. If it in fact isn't used by anyone, I'm fine removing it 👍

@humitos
Copy link
Member Author

humitos commented Jul 6, 2023

There was only 1 project and it's empirical, but I think it was probably a test since they are not using it anymore: https://readthedocs.org/projects/empirical/builds/21194602/ (the YAML shows 3.10) .

I created this metabase question https://ethicalads.metabaseapp.com/question/472-projects-using-pypy-in-a-period?days=30 to make sure my query was correct.

@humitos
Copy link
Member Author

humitos commented Jul 6, 2023

On .com I found 0 projects

humitos added a commit to readthedocs/blog that referenced this pull request Jul 6, 2023
humitos added a commit to readthedocs/blog that referenced this pull request Jul 10, 2023
* Post: remove PyPy3 support

Small and quick post to announce:
readthedocs/readthedocs.org#10514

* Update pypy-support-removed.rst

Co-authored-by: Eric Holscher <[email protected]>

---------

Co-authored-by: Eric Holscher <[email protected]>
@humitos humitos merged commit a1b606f into main Jul 10, 2023
@humitos humitos deleted the humitos/remove-pypy-support branch July 10, 2023 10:07
humitos added a commit that referenced this pull request Jul 10, 2023
humitos added a commit that referenced this pull request Jul 10, 2023
Revert "Build: remove PyPy support (#10514)"

This reverts commit a1b606f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants