-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: remove PyPy support #10514
Build: remove PyPy support #10514
Conversation
We introduced PyPy support as an alternative way to make Sphinx builds faster in #3870 We enabled it in some projects and we tried to communicate this to some CPU intense projects. However, nobody kept using it after doing some experiments with it. I checked our logs and Telemetry data and I found 0 projects using `pypy` in their builds. So, I'm happy to remove its support and simplify our product as its maintainance as well. Even the PyPy project is not using it when building their own documentation: https://readthedocs.org/projects/pypy/builds/21201174/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with this if it doesn't break anything, but I'm a little surprised nobody is using this. It makes me think the query we did was broken, as I don't know if there's any feature we've shipped for a while that nobody is using, but perhaps this is the one!
- ``pypy3.7`` | ||
- ``pypy3.8`` | ||
- ``pypy3.9`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think it makes sense more as an option for builds.tools, but I'm pretty surprised nobody is using this. If it in fact isn't used by anyone, I'm fine removing it 👍
There was only 1 project and it's I created this metabase question https://ethicalads.metabaseapp.com/question/472-projects-using-pypy-in-a-period?days=30 to make sure my query was correct. |
On .com I found 0 projects |
Small and quick post to announce: readthedocs/readthedocs.org#10514
* Post: remove PyPy3 support Small and quick post to announce: readthedocs/readthedocs.org#10514 * Update pypy-support-removed.rst Co-authored-by: Eric Holscher <[email protected]> --------- Co-authored-by: Eric Holscher <[email protected]>
We introduced PyPy support as an alternative way to make Sphinx builds faster in #3870
We enabled it in some projects and we tried to communicate this to some CPU intense projects. However, nobody kept using it after doing some experiments with it.
I checked our logs and Telemetry data and I found 0 projects using
pypy
in their builds. So, I'm happy to remove its support and simplify our product as its maintainance as well.Even the PyPy project is not using it when building their own documentation: https://readthedocs.org/projects/pypy/builds/21201174/
📚 Documentation previews 📚
docs
): https://docs--10514.org.readthedocs.build/en/10514/dev
): https://dev--10514.org.readthedocs.build/en/10514/