Build: remove support for MkDocs <= 0.17.3 #10584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to keep deprecating old feature flags we don't want to support forever. In particular, those that keep our users using pretty old versions of doctools and freeze them in a status that's hard to maintain. This PR removes the `DEFATUL_TO_MKDOCS_0_17_3` feature flag and always install the latest `mkdocs` version. Note this feature flag has `default_true=True` for those projects created _before 2019-04-03_. I did a small DB query and found: ```python >>> Project.objects.filter(pub_date__lt=timezone.datetime(2019, 4, 3), documentation_type='mkdocs').count() 7529 ``` However, note we don't know if these projects are pinning a version of MkDocs, so we don't exactly know how many of those are using this feature. However, it gives us a maximum number at least. On the other hand, taking a look at Metabase, using the build data from the past 6 months I found that we only have 293 projects: https://ethicalads.metabaseapp.com/question/218-projects-using-mkdocs-group-by-version Related #9779
|
We need to merge this PR between 📅 September 27th and October 2nd so it's deployed on October 3rd 📅 |
|
Today, we emailed our users about this. |
|
@stsewd @ericholscher this is review for review and merge. We should merge it before deploying next week due to https://blog.readthedocs.com/defaulting-latest-build-tools/ |
stsewd
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to keep deprecating old feature flags we don't want to support forever. In particular, those that keep our users using pretty old versions of doctools and freeze them in a status that's hard to maintain.
This PR removes the
DEFATUL_TO_MKDOCS_0_17_3feature flag and always install the latestmkdocsversion. Note this feature flag hasdefault_true=Truefor those projects created before 2019-04-03.I did a small DB query and found:
However, note we don't know if these projects are pinning a version of MkDocs, so we don't exactly know how many of those are using this feature. However, it gives us a maximum number at least.
On the other hand, taking a look at Metabase, using the build data from the past 6 months I found that we only have 293 projects:
https://ethicalads.metabaseapp.com/question/218-projects-using-mkdocs-group-by-version
We need to merge this PR between 📅 September 27th and October 2nd so it's deployed on October 3rd 📅
Related #9779