Deprecation: notification and feature flag for build.image config
#10589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define a weekly task to communicate our users about the deprecation of `build.image` using the deprecation plan we used for the configuration file v2 as well. - 3 brownout days - final removal date on October 2nd - weekly onsite/email notification on Wednesday at 11:15 CEST (around 3.5k projects affected) - allow to opt-out from these emails - feature flag for brownout days - build detail's page notification Related: * readthedocs/meta#48 * #10354 * #10587
Define a weekly task to communicate our users about the deprecation of `build.image` using the deprecation plan we used for the configuration file v2 as well. - 3 brownout days - final removal date on October 2nd - weekly onsite/email notification on Wednesday at 11:15 CEST (around ~22k projects affected) - allow to opt-out from these emails - feature flag for brownout days - build detail's page notification Related: * readthedocs/meta#48 * #10354 * #10587
…:readthedocs/readthedocs.org into humitos/deprecate-build-image-config-key
ericholscher
reviewed
Aug 3, 2023
readthedocs/templates/projects/notifications/deprecated_build_image_used_email.txt
Outdated
Show resolved
Hide resolved
readthedocs/templates/projects/notifications/deprecated_build_image_used_email.txt
Show resolved
Hide resolved
agjohnson
reviewed
Aug 3, 2023
humitos
commented
Aug 8, 2023
readthedocs/templates/projects/notifications/deprecated_build_image_used_email.txt
Outdated
Show resolved
Hide resolved
Co-authored-by: Anthony <[email protected]> Co-authored-by: Eric Holscher <[email protected]>
|
I applied all the suggestions. I will update the HTML email and we will be ready to approve and merge, I guess. |
ericholscher
approved these changes
Aug 8, 2023
humitos
added a commit
to readthedocs/blog
that referenced
this pull request
Aug 9, 2023
* Post: Use `build.os` instead of `build.image` Announcement for readthedocs/readthedocs.org#10589 * Apply suggestions from code review Co-authored-by: Eric Holscher <[email protected]> * Update date --------- Co-authored-by: Eric Holscher <[email protected]>
We will start with 3 years timeframe first and then lower it down to 1 year.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define a weekly task to communicate our users about the deprecation of
build.image(or not specifyingbuild.os) using the deprecation plan we used for the configuration file v2 as well.Related:
Closes: