Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder and cleanup project settings page #11470

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Reorder and cleanup project settings page #11470

merged 6 commits into from
Jul 17, 2024

Conversation

ericholscher
Copy link
Member

Fixes #9530

@ericholscher ericholscher requested a review from a team as a code owner July 15, 2024 20:51
@ericholscher ericholscher requested a review from humitos July 15, 2024 20:51
@ericholscher ericholscher requested a review from a team as a code owner July 15, 2024 22:07
@ericholscher ericholscher requested a review from agjohnson July 15, 2024 22:07
description = forms.CharField(
required=False,
max_length=150,
widget=forms.Textarea,
help_text=_("Short description of this project"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still want the textarea widget here, otherwise the input will be pretty small. The length is fixed at 150 anyways.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My goal here is to make the description much less prominent -- when it's a textarea, it's like 5x larger than all the other fields, and it's one of the least important. I think making it a normal input makes it more obvious that it also should be short :)

@humitos humitos enabled auto-merge (squash) July 17, 2024 15:13
@humitos humitos merged commit 2cc701f into main Jul 17, 2024
5 checks passed
@humitos humitos deleted the cleanup-settings branch July 17, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Analytics 4 measurement ID how to add?
2 participants