Notifications: remove unused notification #11573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
force-pushed
the
improve-deploy-key-failure-message
branch
from
8c19795 to
9554248
Compare
humitos
reviewed
Sep 4, 2024
agjohnson
reviewed
Sep 10, 2024
|
I'll re-purpose this PR to delete the unused notification instead (https://github.com/readthedocs/readthedocs-corporate/pull/1866#discussion_r1821118646), since we no longer use the notification that was added here. |
stsewd
changed the title
agjohnson
approved these changes
Oct 31, 2024
humitos
approved these changes
Nov 5, 2024
|
@humitos this needed to be merged with https://github.com/readthedocs/readthedocs-corporate/pull/1866/, this will probably error our application, we can revert this or merge the other PR (I was waiting for Anthony if he had more feedback). |
|
@stsewd OK. I will merge the other PR as well, then. We can make any adjustment we want in a following PR. Thanks for the note. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://github.com/readthedocs/readthedocs-corporate/issues/1806