-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the new Google analytics gtag.js #7691
Conversation
- This applies to docs and to the dashboard - This is backwards compatible with the old UA-XXX properties assuming nothing custom is going on - Supports the new G-XXXX properties - Continues to support disabling analytics and do not track - Sends custom dimensions like before - Shorter cookie expiry like before
Not an issue here, but I did see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks 💯 in my testing. I tested the dashboard and the in-doc pageviews and events. I think we're good to ship it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to see this as well. Had to use chromium bc my firefox was blocking everything :D. I have rebuilt the static assets
With Thank you! |
@JuanDCG - I am at the step where I just added my ReadtheDocs website URL to Google Analytics Web stream, where I have my G-ID now. I pasted this ID in ReadtheDocs admin's
|
Sorry, It was 2 years ago and nowadays I can't help you. |
Fixes #7662
Testing
The easiest way to test this is to set
settings.GLOBAL_ANALYTICS_CODE
and rebuild some documentation and/or view the dashboard and verify that GA is loaded and data is sent (thecollect
call in the screenshot). There should be another call when clicking the flyout menu.Note that I didn't build the static files as part of this PR so you'll need to run
npm run build
to do that. I will do that right before merging this to avoid conflicts.