Convert top navigation to multiple dropdown menus #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
This is for: - #176 But this is still just proof of concept level so far, the mobile menu is a bit broken by this and the actual structure needs shaping up still.
This drops the concept of highlighting the navigation menu item on the page slug, but adds two menus we can put content under to make content discoverable. This now works on desktop and mobile.
agjohnson
force-pushed
the
agj/product-menu
branch
from
69e8441 to
1d58ee0
Compare
|
I've tuned all of the layout up and put some extra links in the navigation dropdown as placeholders mostly. We can return to add individual pages for features next, and it probably makes sense to move some of the links we squirreled away in the footer into at least the desktop product menu instead. The menus look like this on desktop: Screencast.from.2024-04-03.12-01-17.webmAnd this on mobile: Screencast.from.2024-04-03.12-02-09.webm |
agjohnson
changed the title
ericholscher
approved these changes
Apr 4, 2024
I left the submenu option under product too, it looks nice there. The size of the menu was reduced to match the beta dashboard, so elements could fit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a "Product" and "Resources" dropdown navigation menu on desktop and mobile:
This expands our menus to include space for more links, and gives a place to start putting some links that have historically landed in our footer. Some of this content is missing, so the links are not optimized yet -- this is mostly working out structure.
📚 Documentation preview 📚: https://read-the-docs-website--221.com.readthedocs.build/