Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plan pricing to pricing table and edit content #321

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Jul 30, 2024

I was just going to add the pricing at the top,
but ended up doing some copy editing,
and moving content around so that the white blocks are all at the bottom of each section.

FIxes #319


📚 Documentation preview 📚: https://readthedocs-about--321.org.readthedocs.build/

I was just going to add the pricing at the top,
but ended up doing some copy editing,
and moving content around so that the white blocks are all at the bottom of each section.
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great to me. I didn't understand what you meant the first time you mentioned adding the price in the table 😄 . It's pretty clear now 😉 . I'm fine merging this PR as-is

Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a minor note

content/pages/pricing.html Outdated Show resolved Hide resolved
@ericholscher ericholscher enabled auto-merge (squash) August 1, 2024 16:15
@ericholscher ericholscher merged commit 178e6b0 into main Aug 1, 2024
4 checks passed
@ericholscher ericholscher deleted the add-pricing-table branch August 1, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decide if/where to show the Basic plan price
3 participants