Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aeron Cluster fails to start when appVersion >= 1.0.0 #1671

Open
zyulyaev opened this issue Oct 19, 2024 · 0 comments
Open

Aeron Cluster fails to start when appVersion >= 1.0.0 #1671

zyulyaev opened this issue Oct 19, 2024 · 0 comments

Comments

@zyulyaev
Copy link

zyulyaev commented Oct 19, 2024

See test case:
34586a2

Currently AppVersionValidator always receives appVersionUnderTest=0 as part of onNewLeadershipTerm. This happens due to ConsensusPublisher never encoding appVersion to the new leadership term message.

Relevant logs:

1 observations from 2024-10-19 13:05:04.419+0100 to 2024-10-19 13:05:04.419+0100 for:
 io.aeron.cluster.client.ClusterException: ERROR - incompatible version: 1.0.0 log=0.0.0
	at io.aeron.cluster.ConsensusModuleAgent.onNewLeadershipTerm(ConsensusModuleAgent.java:960)
	at io.aeron.cluster.ConsensusAdapter.onFragment(ConsensusAdapter.java:143)
	at io.aeron.FragmentAssembler.onFragment(FragmentAssembler.java:118)
	at io.aeron.logbuffer.TermReader.read(TermReader.java:76)
	at io.aeron.Image.poll(Image.java:324)
	at io.aeron.Subscription.poll(Subscription.java:195)
	at io.aeron.cluster.ConsensusAdapter.poll(ConsensusAdapter.java:69)
	at io.aeron.cluster.ConsensusModuleAgent.doWork(ConsensusModuleAgent.java:359)
	at org.agrona.concurrent.AgentRunner.doWork(AgentRunner.java:304)
	at org.agrona.concurrent.AgentRunner.workLoop(AgentRunner.java:296)
	at org.agrona.concurrent.AgentRunner.run(AgentRunner.java:162)
	at java.base/java.lang.Thread.run(Thread.java:1575)

As a side note: it would be very helpful to be able to distinguish whether we are validating a message in the log versus validating a snapshot. In our case we maintain backward compatibility of snapshotting logic, but maintaining backward compatibility of the log processing logic would be too much of a burden. Please let me know if I should create a separate feature request for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants