-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code on github differs from published code #2103
Comments
@saschak42 We are running into this exact same issue. Our builds have started failing yesterday due to this error:
and googling around, I found this: https://stackoverflow.com/questions/53678786/could-not-find-com-android-toolscommon25-2-3. Given that we can no longer download Can someone please look into this? @fealebenpae @bmunkholm @kneth @nirinchev |
@saschak42 The build file referenced here: https://github.com/realm/realm-js/blob/master/react-native/android/build.gradle is not the one we distribute. This is the one we use to build the android release itself. The |
Hey - looks like you forgot to add a T:* label - could you please add one? |
@cmelchior Thank you for your answer. Yes, that clarifies it. But the problem still exists, because the published gradle file (https://github.com/realm/realm-js/blob/master/react-native/android/publish_android_template) is too old. For example the gradle plugin version is outdated and also the google repository is missing. Can you fix that? |
Yes, we should upgrade those. |
Goals
We need the current version of the Android build.gradle file because of build errors. In the published version (npmjs) the build.gradle file for example has no google() repository. In github these changes were already made in version 2.4.2.
Expected Results
We would expect that the published files on npmjs and the code on github don't differ.
Actual Results
For example the build.gradle file differs completely from the one published on npmjs.
Also the directory structure differs. The android folder on github is a subfolder of react-native. On npmjs the android folder is directly in the root (and the ios folder not).
Steps to Reproduce
Compare the files.
Version of Realm and Tooling
The text was updated successfully, but these errors were encountered: