Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code on github differs from published code #2103

Closed
saschak42 opened this issue Nov 9, 2018 · 5 comments
Closed

Code on github differs from published code #2103

saschak42 opened this issue Nov 9, 2018 · 5 comments

Comments

@saschak42
Copy link

saschak42 commented Nov 9, 2018

Goals

We need the current version of the Android build.gradle file because of build errors. In the published version (npmjs) the build.gradle file for example has no google() repository. In github these changes were already made in version 2.4.2.

Expected Results

We would expect that the published files on npmjs and the code on github don't differ.

Actual Results

For example the build.gradle file differs completely from the one published on npmjs.

Also the directory structure differs. The android folder on github is a subfolder of react-native. On npmjs the android folder is directly in the root (and the ios folder not).

Steps to Reproduce

Compare the files.

Version of Realm and Tooling

  • Realm JS SDK Version: Compared different versions of Realm JS like 2.19.0, 2.18.0, 2.14.2, ...
@HarikaSabbella
Copy link

HarikaSabbella commented Dec 8, 2018

@saschak42 We are running into this exact same issue. Our builds have started failing yesterday due to this error:

A problem occurred configuring project ':realm'.
> Could not resolve all files for configuration ':realm:classpath'.
   > Could not find com.android.tools:common:25.3.3.
     Searched in the following locations:
         https://jcenter.bintray.com/com/android/tools/common/25.3.3/common-25.3.3.pom
         https://jcenter.bintray.com/com/android/tools/common/25.3.3/common-25.3.3.jar

and googling around, I found this: https://stackoverflow.com/questions/53678786/could-not-find-com-android-toolscommon25-2-3. Given that we can no longer download com.android.tools:common:25.3.3 from jcentral() and need to use google(), it's even more critical that this issue is addressed. Is it possible to bump the Android build tools version to 3.1+ and add google() to the the version of realm published to NPM?

Can someone please look into this? @fealebenpae @bmunkholm @kneth @nirinchev

@cmelchior
Copy link
Contributor

cmelchior commented Dec 10, 2018

@saschak42 The build file referenced here: https://github.com/realm/realm-js/blob/master/react-native/android/build.gradle is not the one we distribute. This is the one we use to build the android release itself. The build file we release is this one: https://github.com/realm/realm-js/blob/master/react-native/android/publish_android_template, it just gets renamed to build.gradle during the release. I hope that clarifies it?

@realm-probot
Copy link

realm-probot bot commented Dec 10, 2018

Hey - looks like you forgot to add a T:* label - could you please add one?

@saschak42
Copy link
Author

@cmelchior Thank you for your answer. Yes, that clarifies it. But the problem still exists, because the published gradle file (https://github.com/realm/realm-js/blob/master/react-native/android/publish_android_template) is too old. For example the gradle plugin version is outdated and also the google repository is missing. Can you fix that?

@cmelchior
Copy link
Contributor

Yes, we should upgrade those.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants