Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] - Clip Skip in Parameter Generator node #55

Open
Latentnaut opened this issue Jan 31, 2024 · 4 comments
Open

[FEATURE REQUEST] - Clip Skip in Parameter Generator node #55

Latentnaut opened this issue Jan 31, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@Latentnaut
Copy link

Summary

Just wanted to say congratulations for this package, it's amazing to have all parameters in (almost) one node.
I only miss Clip Skip to complete the whole thing. Have you ever think about it?
Thank you this marvellous job.

Basic Example

Clip Skip in SD Parameter Generator.

Reference Issues.

No response

@Latentnaut Latentnaut added the question Further information is requested label Jan 31, 2024
@receyuki
Copy link
Owner

receyuki commented Feb 6, 2024

Thank you for your feedback. About the selection of parameters, I personally tend to choose the most commonly used ones. Clip Skip, however, seems to be less common.
I would recommend placing a primitive node next to the Parameter Generator node and connecting it to the stop_at_clip_layer. What do you think? Of course, if more users believe Clip Skip is necessary, I will add it to the parameters.

截屏2024-02-06 下午8 52 47

@receyuki
Copy link
Owner

receyuki commented Feb 6, 2024

BTW, please post issues related to the comfyui node to another repo next time.

@receyuki receyuki transferred this issue from receyuki/stable-diffusion-prompt-reader Feb 6, 2024
@Latentnaut
Copy link
Author

I understand you want to keep the esencial parameters in one place. Otherwise it could be overwhelming for some user.

But hey, this node suppose to be to more advanced users, in my opinion.

For me perspective, adding one parameter more would help me to clean my starter models.

One solution could be creating two types of SD Parameter Generator: standard and extensive. First one like the current one and the second with more parameters. It reminds me the amazing Context and Context Big nodes from rgthree

But, hey, this is a lot of work, I really appreciate the current state.

Peace and love

@receyuki receyuki added enhancement New feature or request and removed question Further information is requested labels Feb 13, 2024
@receyuki receyuki changed the title CLIP Skip [FEATURE REQUEST] - Clip Skip in Parameter Generator node Feb 13, 2024
@receyuki
Copy link
Owner

In fact, the current parameter generator is already an advanced version. I have considered making a simpler version, but it wouldn't make everyone's life easier, it would only increase my workload.

Anyway, I will keep this issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants