Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input validation on form fields (e.g., to prevent insertion of zero-width space characters). #233

Open
kfogel opened this issue Apr 16, 2020 · 1 comment
Labels
enhancement A minor improvement, not a full-fledged feature. M

Comments

@kfogel
Copy link
Member

kfogel commented Apr 16, 2020

Invalid user-entered data has caused us problems before. We should perform input validation on form fields where possible.

@kfogel
Copy link
Member Author

kfogel commented Apr 16, 2020

Besides the obvious field from issue #232, we should do input validation in any field that takes one or more email addresses and separates them with commas when there are multiple addresses. For example, on the "Scheduler dispatch export recipient" field in the same chapter, there was a single email address followed by a comma.

@bnazari and I agreed that that comma should be removed, and he did so, but it should never have been there in the first place. Note that no post-input code strips it out, either: on the NCCR administrative view page, the comma was appearing at the end the email address for that field in the collective "Config" value, until we removed it.

@kfogel kfogel added enhancement A minor improvement, not a full-fledged feature. M labels Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A minor improvement, not a full-fledged feature. M
Projects
None yet
Development

No branches or pull requests

1 participant