XML support crashes when workspace folders are empty

[Chadehoc]

I had used this extension with success some times ago (say, last month), including schema validation and formatting.

When I came back to it, editing the same XML files I did before, suddenly the only item offered by the command palette had become "XML: Open XML Documentation", and nothing works (validation, formatting, auto-closing tag when typing "/"...).

I have tried to reinstall the extension, remove every personnalized settings, install the RC version, disable all other extensions... in vain. (Note: vscode-xml was my latest installed extension.)

[angelozerr]

Could you enable trace with xml.trace.server=verbose please and share the log.Thanks!

[Chadehoc]

Thanks, here is the log, and the listed "getWorkspaceUri" was a hint to the solution: I had tried to use workspaces (*.code-workspace file). Removing the workspace file and opening the XML files from scratch works fine again. So the issue has a workaround for my immediate need.

Maybe the title should become "is broken by workspace files"?

2023-11-07 14:36:06.349 [error] Activating extension redhat.vscode-xml failed due to an error:
2023-11-07 14:36:06.349 [error] TypeError: Cannot read properties of undefined (reading 'uri')
	at t.getWorkspaceUri (c:\Users\Eric\.vscode\extensions\redhat.vscode-xml-0.26.1-win32-x64\dist\extension.js:2:327150)
	at t.getVariableSubstitutedAssociations (c:\Users\Eric\.vscode\extensions\redhat.vscode-xml-0.26.1-win32-x64\dist\extension.js:2:324444)
	at t.getXMLSettings (c:\Users\Eric\.vscode\extensions\redhat.vscode-xml-0.26.1-win32-x64\dist\extension.js:2:323330)
	at c:\Users\Eric\.vscode\extensions\redhat.vscode-xml-0.26.1-win32-x64\dist\extension.js:2:279673
	at c:\Users\Eric\.vscode\extensions\redhat.vscode-xml-0.26.1-win32-x64\dist\extension.js:2:280300
	at Generator.next (<anonymous>)
	at c:\Users\Eric\.vscode\extensions\redhat.vscode-xml-0.26.1-win32-x64\dist\extension.js:2:278930
	at new Promise (<anonymous>)
	at i (c:\Users\Eric\.vscode\extensions\redhat.vscode-xml-0.26.1-win32-x64\dist\extension.js:2:278675)
	at t.startLanguageClient (c:\Users\Eric\.vscode\extensions\redhat.vscode-xml-0.26.1-win32-x64\dist\extension.js:2:279456)
	at c:\Users\Eric\.vscode\extensions\redhat.vscode-xml-0.26.1-win32-x64\dist\extension.js:2:294745
	at Generator.next (<anonymous>)
	at s (c:\Users\Eric\.vscode\extensions\redhat.vscode-xml-0.26.1-win32-x64\dist\extension.js:2:293491)

[angelozerr]

Thanks so much @Chadehoc for your feedback and trace. is it possible to share your vscode project which causes the problem please.

[Chadehoc]

Trying to reproduce a stripped-down example, it seems as simple as creating an empty example.code-workspace file!

{
	"folders": [],
	"settings": {}
}

I can't check for sure that my original code-workspace file was indeed empty (it was deleted and rewritten since), but it is possible, because it had been a simple try out of curiosity. Anyway, it reproduces the activation error whatever the XML file.

[angelozerr]

@Chadehoc I did a fix in #941

[angelozerr]

@Chadehoc my PR has been merged, tomorrow you should enjoy with vscode-xml prerelease https://github.com/redhat-developer/vscode-xml#contributing (checks the date before installing).

Please give us feedback if it fixes your issue.