Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alpine lemminx server #1016

Merged
merged 5 commits into from
Jul 18, 2024

Conversation

cirolosapio
Copy link
Contributor

fixes #1015

Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for filing this. Overall, I think this should fix the issue. Just a couple of small things I have comments on.

src/server/binary/binaryServerStarter.ts Outdated Show resolved Hide resolved
src/server/binary/binaryServerStarter.ts Outdated Show resolved Hide resolved
@rgrunber rgrunber merged commit ae488d9 into redhat-developer:main Jul 18, 2024
1 check passed
@cirolosapio cirolosapio deleted the fix-alpine-lemminx-server branch July 18, 2024 10:35
@cirolosapio
Copy link
Contributor Author

hi @rgrunber is there an ETA when this bugfix will be released ?

@datho7561
Copy link
Contributor

Oops, hopefully today. We also release pre-release versions of the extension daily; if you switch to pre-releases in VS Code it should be available there.

@cirolosapio
Copy link
Contributor Author

i use devcontainer and the extensions list are defined in the devcontainer.json file and it is not possible to specify the pre-release version, so it's never installed

@datho7561
Copy link
Contributor

Supposedly: microsoft/vscode#149383 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lemminx-alpine server not found
3 participants