underscore (italics) markdown in preview disrupted by cursor logic

[clem4962]

Add a fresh paragraph to a page, highlight it, then hit the Italics button, then Preview. The italics will not render (it will display plain text with underscores):

_my new text_

There are other variations, such as leaving the cursor on a subsequent blank line etc, but all occur because the cursor logic in renderer.py has modified the line to this:

_my new text_CuRsoRm4g1cW0Rd

which the markdown rendering no longer recognises.

(Using asterisks instead of underscores works fine.)

Possibly this might be fixed by changing the magic cursor word to an html comment, eg <!--CuRsoRm4g1cW0Rd--> ? This worked in my somewhat limited testing.

OTOH, I'm not too sure what purpose the cursor processing actually serves. Is it required in some other use case other than preview?

[redimp]

Hey @clem4962, I can reproduce this bug.

You are right, the CuRsoRm4g1cW0Rd is used for previewing the location of the page where you placed your cursor, so that you dont have to scroll and search for what you've just edited.

If you mark a paragraph, hit Italics as you described and place the cursor below, before you hit Preview it's rendered correctly.

[redimp]

Released in v2.9.0.

[rhartmann]

Hi @redimp, you might want to have another look into this.

I noticed <!-- CuRsoRm4g1cW0Rd --> showing up in a code block in preview mode. It seems to misbehave when the cursor is in a code block. When you switch to preview, the magic word prints as part of the code block (and the preview does not scroll to the position).

This also happens if the cursor is on a directly adjacent line (line directly before or after the code block), even if that line is not blank. No matter whether the code block uses single ticks, triple ticks or four-space indention.

Exceptions I found so far:

• Code blocks with triple ticks and a syntax specifier such as python and/or line numbers: The magic word does not show up but the indentation of the code or the line numbers is messed up, depending on where the cursor is; this one is particularly weird: the mess is not necessarily near the cursor position
• Non-blank line directly before indented code blocks: the code block becomes regular text
• Non-blank line directly after indented code block: magic word won't show up in the code block; interestingly now also if the cursor is on the last line of the code block itself
  • Exception to the exception: If an indented code block is directly followed by a 1-tick or 3-tick code block 😄

[redimp]

Thx @rhartmann for the detailed analysis ... I didn't think through that adding the html comment tags would of course make other parsers interact with it.

[redimp]

Fix released in v2.9.2.