The "Retain page name case" and "Enable Git Web server" options get reset when "Application preferences" are saved

[mattock]

The "Application preferences" form touches parts of Otterwiki configuration it should not. How to reproduce:

1. Go to Otterwiki Settings as an admin user
2. Go to "Content and editing"
3. Enable "Retain page name case" and/or "Enable Git Web server"
4. Go to "Application preferences"
5. Make any changes, e.g. edit "Site description"
6. Go back to "Content and editing"
7. Notice how "Retain page name case" and/or "Enable Git Web server" are now disabled

The culprit seems to be here:

• https://github.com/redimp/otterwiki/blob/main/otterwiki/preferences.py#L157

The "handle_app_preferences" method should not include "retain_page_name_case" or "git_web_server" checkboxes, which are invisible anyways because they're not referred to in the matching template file:

• https://github.com/redimp/otterwiki/blob/main/otterwiki/templates/admin.html

[redimp]

Confirmed. Will fix this and make a new release later today tomorrow. Thx @mattock for digging into it!

[redimp]

Fix released in v2.9.2.