Broken links in Page Index

[rhartmann]

The Page Index shows broken links for pages whose page name and page title (first header line) match in letters but not in case. The link href uses the page title, not the page name (derived from the filename).

Steps to reproduce:

• Start fresh container with redimp/otterwiki:2-slim (v2.9.1)
  • I set environment variable RETAIN_PAGE_NAME_CASE=true (or Retain page name case. under Settings > Content and Editing Preferences), but the bug also occurs without this setting
• Create new page such as ExamplePage
• In the editor, change the case of the title line such as Examplepage or examplepage and save the page
  • When altering the title line (beyond just changing the case) like This is an Example Page, the bug does not occur
• Go to Page Index, get broken link

I had a look into this and tried to provide a quick fix, but wasn't quite sure how to fix it. I suspect the issue here:

otterwiki/otterwiki/helper.py

Lines 190 to 199 in 80f1190

	if i == len(arr) - 1 and header is not None:
	hint = header
	if (hint != part and hint.lower() == part.lower()) or (
	hint == part and hint != part.lower()
	):
	arr[i] = hint
	else:
	arr[i] = (
	part if app.config["RETAIN_PAGE_NAME_CASE"] else titleSs(part)
	)

Or maybe here:

otterwiki/otterwiki/wiki.py

Lines 162 to 176 in 80f1190

	pagetoc.append(
	(
	header[2], # depth
	header[3], # title without formatting
	url_for(
	"view",
	path=get_pagename(
	f,
	full=True,
	header=pagename,
	),
	_anchor=header[4],
	),
	)
	)

[redimp]

Confirmed, i can reproduce this. Will look into it. Thx @rhartmann for digging into this.

[redimp]

Fix released in v2.9.2.