Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support issuing Latency commands #1246

Closed
CodingFabian opened this issue Mar 24, 2016 · 15 comments · Fixed by #3729
Closed

Support issuing Latency commands #1246

CodingFabian opened this issue Mar 24, 2016 · 15 comments · Fixed by #3729

Comments

@CodingFabian
Copy link

Currently it is not possible to issue latency commands using jedis. You need to write your own client to issue custom commands.
There are a couple of latency commands (latency history, latency latest) that could be executed. ideally automatically guarded against the redis version (2.8.13 +)

@marcosnils
Copy link
Contributor

@CodingFabian good catch. As you seem to need these commands, what do you think about crafting a PR so Jedis can include this functionality?

@CodingFabian
Copy link
Author

Sure, I am just a bit lost where this should go:
JedisCommands, MultiKeyCommands, AdvancedJedisCommands, ScriptingCommands, BasicCommands, ClusterCommands, SentinelCommands ?

@marcosnils
Copy link
Contributor

@CodingFabian I'd start adding it in the BasicCommands interface and move from there.

@sheinbergon
Copy link
Contributor

@marcosnils what's the status of this feature request ? Has this been implemented yet ?

@marcosnils
Copy link
Contributor

@sheinbergon there's no open PR, so no. @CodingFabian ping?

@CodingFabian
Copy link
Author

Nope, havent done anything so far.

@sheinbergon
Copy link
Contributor

@marcosnils feel free to assign this to me . I will work on it in the upcoming weeks 👍

@CodingFabian
Copy link
Author

cool thanks!

@marcosnils
Copy link
Contributor

@sheinbergon no need to assign, maybe @CodingFabian wanted/needed to implement it?. @CodingFabian ?

@sheinbergon
Copy link
Contributor

sheinbergon commented Jul 16, 2016

@CodingFabian I'm guessing you'd like to support LATENCY LATEST , LATENCY HISTORY and LATENCY RESET , right ? Is there anything I missed ?

@marcosnils would you like to add anything else ?

@sheinbergon
Copy link
Contributor

@CodingFabian @marcosnils ?

@marcosnils
Copy link
Contributor

@sheinbergon go ahead and implement it @CodingFabian timed out.

@CodingFabian
Copy link
Author

I actually had a weekend.
yes. LATENCY LATEST and LATENCY HISTORY is what we wanted.

Copy link

This issue is marked stale. It will be closed in 30 days if it is not updated.

@Lcarrot
Copy link
Contributor

Lcarrot commented Feb 19, 2024

Hello, can i try to solve this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants