Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with React 19 types #2162

Closed
eps1lon opened this issue Apr 26, 2024 · 3 comments · Fixed by #2168
Closed

Compatibility with React 19 types #2162

eps1lon opened this issue Apr 26, 2024 · 3 comments · Fixed by #2168

Comments

@eps1lon
Copy link
Contributor

eps1lon commented Apr 26, 2024

What is the new or updated feature that you are suggesting?

Compatibility with React 19 types.

I used npx types-react-codemod@latest that solved most of the issues. All necessary changes can be cherry-picked from eps1lon#1. You can also check out https://github.com/users/eps1lon/projects/3/views/9 to get an overview what other apps/libraries need to do for migration.

Why should this feature be included?

To allow seamless migration to React 19.

What docs changes are needed to explain this?

None

@markerikson
Copy link
Contributor

Can you clarify what actual changes are needed?

@eps1lon
Copy link
Contributor Author

eps1lon commented Apr 26, 2024

@markerikson
Copy link
Contributor

markerikson commented May 2, 2024

@eps1lon can you clarify how we have an implicit transitive dependency on @types/prop-types?

nm, I see it - it's our one file that actually does import from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants