Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CesiumMovementEvent startPosition field is mis-named #122

Closed
markerikson opened this issue Oct 14, 2019 · 2 comments · Fixed by #129
Closed

CesiumMovementEvent startPosition field is mis-named #122

markerikson opened this issue Oct 14, 2019 · 2 comments · Fixed by #129
Labels
bug

Comments

@markerikson
Copy link

This is the current definition:

https://github.com/darwin-education/resium/blob/295f75f5ecbd7379a6818ab23d1e161651979291/src/core/EventManager.ts#L46-L50

The field should be named startPosition, not startPositon
@rot1024
Copy link
Member

rot1024 commented Nov 8, 2019

Thank you for reporting. It will be fixed next version.

@rot1024 rot1024 added the bug label Nov 8, 2019
rot1024 added a commit that referenced this issue Nov 8, 2019
@rot1024
fix: typo (#122)
6fd266c
@rot1024 rot1024 mentioned this issue Nov 11, 2019
Merged
rot1024 added a commit that referenced this issue Nov 11, 2019
@rot1024
Support Cesium v1.63 (#129)
2c16394 
* chore: upgrade deps

* chore: unify eslint config

* chore: set typescript version for vscode

* fix: typo (#122)

* chore: regenerate yarn.lock

* chore: unify eslint config

* doc: fix storybook config

* chore: fix imports

* chore: add eslint-plugin-react-hooks

* chore: enable tree shaking
@rot1024
Copy link
Member

rot1024 commented Nov 11, 2019

v1.8.1 has been released. Try it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Cesium v1.63 reearth/resium
2 participants
@markerikson @rot1024