Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

canonical #1472

Closed
Tranquility opened this issue Mar 17, 2012 · 6 comments
Closed

canonical #1472

Tranquility opened this issue Mar 17, 2012 · 6 comments
Labels
2-0-stable Feature Request

Comments

@Tranquility
Copy link
Contributor

There are about 3 different urls for every page:

/pages/mypage
/parent/mypage
/mypage

and all these can have an additional slash at the end. So I think it would be great if https://github.com/resolve/refinerycms/blob/master/core/app/views/refinery/_head.html.erb#L7 canonical would be set for all pages.
@parndt
Copy link
Member

parndt commented Mar 17, 2012

Agreed

@simi
Copy link
Member

simi commented Mar 20, 2012

There sohuld be only one url per page.

@parndt
Copy link
Member

parndt commented Mar 20, 2012

What I mean is, canonical should be set for only one version of the page and the others should set that value too.

@knewter
Copy link

knewter commented Apr 23, 2012

So what should canonical be set to by default? /parent/mypage seems the sensible choice but I don't know what's preferred by other users necessarily.

@parndt
Copy link
Member

parndt commented Apr 23, 2012

To the marketable path; if allowed. I've got half a patch.

@parndt parndt closed this as completed in 408fd16 May 12, 2012
@parndt
Copy link
Member

parndt commented May 12, 2012

Here's my half done patch. Would somebody else like to take this and improve it please?

resolve/refinerycms@2-0-stable...canonical

Check out branch canonical and work from there or ditch my code and make it better, please :-)

ghoppe pushed a commit to ghoppe/refinerycms that referenced this issue May 28, 2012
@parndt
Added support for @canonical in pages_controller.
bcec0bb 
Fixes refinery#1472

Conflicts:

	pages/app/models/refinery/page.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2-0-stable Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@knewter @parndt @Tranquility @simi