Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple rx._x.asset issues #3623

Closed
benedikt-bartscher opened this issue Jul 4, 2024 · 0 comments · Fixed by #3624
Closed

Multiple rx._x.asset issues #3623

benedikt-bartscher opened this issue Jul 4, 2024 · 0 comments · Fixed by #3624
Labels
bug Something isn't working

Comments

@benedikt-bartscher
Copy link
Contributor

benedikt-bartscher commented Jul 4, 2024 •
edited
Loading

  • Assets should not be checked and copied in backend only mode. Even if you do not put them in globals, they will for example be executed if you use them in a @rx.page which will be loaded. Even in backend only mode.
  • Local/Normal asset support - Assets which are in the local assets/ directory should not be copied to assets/external. But we can still validate that the asset exists and return the serving path.

@abulvenz
@benedikt-bartscher benedikt-bartscher added the bug Something isn't working label Jul 4, 2024
@benedikt-bartscher benedikt-bartscher mentioned this issue Jul 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rx._x.asset improvements benedikt-bartscher/reflex
1 participant
@benedikt-bartscher