Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zlib decompression fails #205

Closed
felipe-linares opened this issue Jul 31, 2023 · 2 comments
Closed

Zlib decompression fails #205

felipe-linares opened this issue Jul 31, 2023 · 2 comments

Comments

@felipe-linares
Copy link

felipe-linares commented Jul 31, 2023 •
edited
Loading

Seems like a known issue? Tested on facebook.com using the safari TLS.

#95 (comment)

Zlib decompression returns correct n but also return EOF error.

If you just ignore the error zlib read error it works, but obviously not the ideal scenario.
@gaukas
Copy link
Contributor

gaukas commented Jul 31, 2023 •
edited
Loading

Hmm. I think currently uTLS supports only brotli and zstd while the only preset parrot advertising zlib is HelloSafari_16_0.

While we would be happy to accept a PR addressing this issue with zlib implementation, are there any more recent popular TLS fingerprints advertising zlib tather than brotli? (I am guessing Safari?)

@hwh33 hwh33 mentioned this issue Aug 1, 2023
Merged
@gaukas
Copy link
Contributor

gaukas commented Aug 2, 2023

Fixed in #206.

@gaukas gaukas closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaukas @felipe-linares