Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedisReply is broken #206

Closed
jupenur opened this issue Apr 1, 2013 · 0 comments
Closed

RedisReply is broken #206

jupenur opened this issue Apr 1, 2013 · 0 comments
Labels

Comments

@jupenur
Copy link
Contributor

jupenur commented Apr 1, 2013

The next method in RedisReply attempts to operate on a TCP connection without acquiring it first, so it will fail when used outside a RedisConnection. I can think of two possible ways of fixing it:

  1. Make RedisReply private and never return it from any of the client methods, or...
  2. Reserve the connection for as long as a corresponding RedisReply exists.

The first one makes more sense to me.

I can take this on myself as soon as I have the time, but I have no idea when that'll actually be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants