fix Issue #285 - getOption returns false when option is set on command l... #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…command line - It only returned true when an option from a config file was overwritten. - Workaround the missing return value of std.getopt.getopt by comparing the lengths of the passed args.
|
Thanks! Looking at the code, my initial reaction also was that the command line should override the config setting and not vice versa. @CyberShadow, was the order here intentional? |
Yes, absolutely. The general convention is: command line > environment > user config file > global config file > hardcoded defaults. If the order in the code was different, that's a bug. |
|
Okay thanks, I'll pull and make the change then. |
s-ludwig
added a commit
that referenced
this pull request
Oct 3, 2013
fix Issue #285 - getOption returns false when option is set on command l...
s-ludwig
added a commit
that referenced
this pull request
Oct 3, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ine
was overwritten.
the lengths of the passed args.