add MongoCollection.aggregate helper method

[japplegame]

Description: http://docs.mongodb.org/manual/reference/method/db.collection.aggregate

According to description, aggregate should return object with array of documents and status code. But this implementation returns just array of documents, because status code is always equal 1 and completely useless.

[mihails-strasuns]

Can you please squash the commits into one? (http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)

[japplegame]

Bad idea, because GiHub says:

"Warning: It is considered bad practice to rebase commits which you have already pushed to a remote repository. Doing so may invoke the wrath of the git gods"

[s-ludwig]

"Warning: It is considered bad practice to rebase commits which you have already pushed to a remote repository. Doing so may invoke the wrath of the git gods"

It's kind of acceptable if done on a branch that is only meant as the source for a pull request, though (or even necessary when the pull request gets out of date).

But staying on topic, otherwise everything looks good to merge..... now you closed it! ;)

[mihails-strasuns]

@japplegame
GitHub says a lot of wrong things about git :P
For pull request branches it is not only fine but almost necessary as their commits will go upstream as-is upon merging and having a clean history helps a lot in the long term.

[s-ludwig]

@japplegame Thanks a lot, looks good now. Mind if I reopen and pull in this state?

[japplegame]

Whoaaa. I'm really confised with GitHub. Shame!
I deleted branch and created a new. Now I can create new pull request :)

[s-ludwig]

Hm... right there are actually four commits now ;)

[s-ludwig]

Now it looks OK again. Kind of weird to observe real-time updates on github.

[mihails-strasuns]

One commit again :D
@japplegame all you needed to do is git push -f origin mongo_aggregate after squashing :)

[japplegame]

Ok. :)
What should I do now? Just reopen pull request?

[mihails-strasuns]

Yes (though @s-ludwig can do it on his own)

[s-ludwig]

Success! :)