-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[meta] Ship v1.16 #185
Comments
I pushed work for this in https://github.com/rackt/history/tree/1.16-no-warnings |
BTW, this is relevant to fixing remix-run/react-router#2682 |
This looks great. React Router 1.0.2 fixed the issue for people who are doing a fresh npm2 or npm3 install of react router. History 1.16 will fix the issue for
Then we just leave 1.16 out there forever, and do the new strategy (new API with backwards compatibility with deprecation warnings are in a new major version) moving forward. |
👍 to this, I think this is the cleanest way we can set things up for now. That said, I'd think it'd be okay to do 1.17.x with the deprecation warnings as long as we release it w/React Router at the same time. The inconvenience this time around was just that users had no way to fix the deprecation warnings. Sort of like the parent/owner context stuff in React 0.13. |
If we ship 1.17 with warnings then people with pinned routers at <1.0.2 will still have issues. |
I think at that point we should be willing to say "tough luck" if they pin to 1.0.x of React Router but let the minor version of |
I think we need to ship 2.0 with warnings. 3.0 will remove them all. |
I'm still getting a warning from the render method of Link
Apparently it has be fixed but this means that we still have to wait for a new version of the router, haven't we? |
I fixed
createLocation
in e1e0882 and added the deprecation warnings for thestate
arg.At this point I'd like to ship a version 1.16 that doesn't emit all the warnings. Then we can ship a router version 1.0.3 that uses it as a peer dep and stop breaking people's builds. I think the easiest way to do this is to just comment out all the warnings in history. This will at least get us back to a place where people who used
history: "^1.15.0"
in their package.json have a build that works.The text was updated successfully, but these errors were encountered: