Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links without locale & branch are broken #123

Closed
MichaelDeBoey opened this issue Oct 16, 2024 · 2 comments
Closed

Links without locale & branch are broken #123

MichaelDeBoey opened this issue Oct 16, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@MichaelDeBoey
Copy link
Member

https://reactrouter.com/start/concepts used to redirect to https://reactrouter.com/en/main/start/concepts, but this doesn't seem to work anymore

We use these in several of the Remix docs, so all these links are now broken

@brophdawg11
Copy link
Contributor

We removed this "version-less" redirect because it was prone to breaking across major releases. For example, when we remove json in v7, https://reactrouter.com/fetch/json would have started to 404 because the links will always redirect to the latest version and v7 doesn't have that API. Instead, we need to always include some known good version for these links - so we moved to a format of https://reactrouter.com/v6/fetch/json which will redirect to the latest in the v6 release line.

We need to go fix some of these old types of links - I did a handful for RR in remix-run/react-router#12141 and have some local changes for the Remix repo as well that I'll get pushed shortly and will drop a link here too. If you see others that aren't in the source code please let us know!

@brophdawg11 brophdawg11 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2024
@brophdawg11
Copy link
Contributor

Remix PR remix-run/remix#10130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants