fix(react-router-dom): fix submitter serialization (alt approach) #9866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ecf4c77 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
This is the RR port of remix-run/remix#4475 Bring `<Form>` submissions in line with the spec with respect to how and where form submitters are serialized within the data set. We accomplish this by constructing the form data set ourselves according to the spec. Problems fixed: 1. Serialize submitters in tree order (i.e. where they appear in the DOM) 2. Serialize Image Button submitter correctly (i.e. separate x and y coordinate entries, rather than a single empty entry) 3. Stop sending multiple entries in older WebKit References: remix-run/remix#4342 Spec: https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#constructing-form-data-set
jenseng
force-pushed
the
fix-form-submitters-alt
branch
from
5a456a7
to
ecf4c77
Compare
|
Closing this in favor of #9865 (which will likely end up much simpler too, since it looks like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔈 NOTE: I have two proposed fixes; this is the alternate one, the primary proposal is #9865. This PR is the RR port of remix-run/remix#4475. 🔈
Bring
<Form>submissions in line with the spec with respect to how and where form submitters are serialized within the data set. We accomplish this by constructing the form data set ourselves according to the spec.Problems fixed:
Notes: required a couple more jsdom polyfills in order to test it, but we should be able to upgrade and remove those soon 🤞
References: remix-run/remix#4342
Spec: https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#constructing-form-data-set