-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when //
is used as Link's to
#5440
Comments
To give more context: We at @webstudio-is have a case where the |
This sounds related to a bug I had filed a few months ago #4422 Looks like they have it fixed for an upcoming version. |
This issue has been automatically marked stale because we haven't received a response from the original author in a while 🙈. This automation helps keep the issue tracker clean from issues that are not actionable. Please reach out if you have more information for us or you think this issue shouldn't be closed! 🙂 If you don't do so within 7 days, this issue will be automatically closed. |
This is fixed by remix-run/react-router#10367 and will be available once Remix 1.16.0 is released. |
Great work! Thank you! |
What version of Remix are you using?
1.12.0
Are all your remix dependencies & dev-dependencies using the same version?
Steps to Reproduce
<Link to="//">...</Link>
Same problem with some other values of
to
for example"http://"
, so I think this should be fixed by wrappingnew URL()
into atry..catch
rather than checking for known fail cases.Expected Behavior
Page doesn't crash, instead
<a href="//">...</a>
is renderedActual Behavior
The page crashes with a error
Failed to construct 'URL': Invalid URL
The text was updated successfully, but these errors were encountered: