Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(github): GraphQL cache for datasources #19059

Merged
merged 39 commits into from
Jan 6, 2023
Merged

feat(github): GraphQL cache for datasources #19059

merged 39 commits into from
Jan 6, 2023

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Nov 23, 2022 •
edited
Loading

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov marked this pull request as ready for review November 29, 2022 09:36
@zharinov zharinov requested review from viceice and rarkins November 29, 2022 09:36
@zharinov zharinov changed the title feat: GraphQL cache for GitHub feat(github): GraphQL cache for datasources Nov 29, 2022
@zharinov zharinov requested a review from viceice November 30, 2022 07:03
@zharinov zharinov mentioned this pull request Nov 30, 2022
Merged
6 tasks
rarkins
rarkins reviewed Nov 30, 2022
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably need this logic described in a markdown file next to the code itself, for the benefit of future maintainers

lib/util/github/graphql/cache-adapters/abstract-cache-adapter.ts Outdated Show resolved Hide resolved
lib/util/github/graphql/cache-adapters/abstract-cache-adapter.ts Outdated Show resolved Hide resolved
viceice
viceice reviewed Dec 8, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty complex.
can you extract the rename to a seperate PR, so we have less changes?
or is that too complicated ?

lib/util/github/graphql/cache-adapters/memory-cache-adapter.spec.ts Outdated Show resolved Hide resolved
lib/util/github/graphql/cache-adapters/memory-cache-adapter.ts Outdated Show resolved Hide resolved
lib/util/github/graphql/cache-adapters/package-cache-adapter.ts Outdated Show resolved Hide resolved
@zharinov zharinov mentioned this pull request Dec 23, 2022
Merged
6 tasks
@zharinov zharinov mentioned this pull request Dec 25, 2022
Merged
6 tasks
@zharinov zharinov requested review from viceice and rarkins December 27, 2022 07:41
@zharinov
Copy link
Collaborator Author

zharinov commented Dec 27, 2022 •
edited
Loading

Asked your review folks if you can do it anytime soon. If not, it's okay and I'm working on further PRs anyway.

viceice
viceice reviewed Dec 27, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/util/github/graphql/cache-strategies/package-cache-strategy.ts Show resolved Hide resolved
@viceice viceice enabled auto-merge (squash) December 27, 2022 08:40
@zharinov zharinov mentioned this pull request Jan 1, 2023
Merged
6 tasks
@viceice viceice merged commit 89965bd into renovatebot:main Jan 6, 2023
@viceice viceice deleted the feat/github-graphql-cache-wip branch January 6, 2023 08:33
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.85.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mrsimo mrsimo mentioned this pull request Jan 26, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-implement GraphQL-based cache for github-tags and github-releases
4 participants
@zharinov @renovate-release @viceice @rarkins