-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(docker): add ghworkflows example for GAR with Workload Identity #30692
docs(docker): add ghworkflows example for GAR with Workload Identity #30692
Conversation
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a list of steps is easier to read and skim than the plain sentences we have now. Also we should break up the wall of text at the bottom.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with the docs. We still need a maintainer to check the technical accuracy of the text though.
🎉 This issue has been resolved in version 38.52.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
update documentation to show a proper example of docker data source configuration with GitHub workflows, workload identity and Google artifact registry.
Context
#29618 (reply in thread)
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: