feat(manager/kubernetes): only extract valid images #31618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslafy-z
changed the title
aslafy-z
changed the title
aslafy-z
changed the title
viceice
requested changes
Sep 26, 2024
aslafy-z
force-pushed
the
patch-2
branch
2 times, most recently
from
b4eeddf to
5172de5
Compare
Signed-off-by: GitHub <[email protected]>
auto-merge was automatically disabled
September 27, 2024 15:34
Head branch was pushed to by a user without write access
|
@viceice I addressed the requested change. Can you please review again? Thank you |
rarkins
added
the
auto:no-done-comments
|
Hi there, You are using Good luck, The Renovate team |
viceice
approved these changes
Sep 28, 2024
viceice
reviewed
Sep 28, 2024
|
🎉 This PR is included in version 38.101.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The Kubernetes manager now only extract valid images.
It uses the Docker implementation of the OCI spec: https://github.com/distribution/reference/blob/v0.6.0/regexp.go.
Extracted & converted with https://go.dev/play/p/ZwF3vvRD9Rs.
Context
I had some gotemplates in my yaml files and did not want the kubernetes manager to extract images with these templates.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: