Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Migrate Renovate Config" PR should not apply to package.json contents #33116

Closed
rarkins opened this issue Dec 15, 2024 Discussed in #33078 · 1 comment · Fixed by #33122
Closed

"Migrate Renovate Config" PR should not apply to package.json contents #33116

rarkins opened this issue Dec 15, 2024 Discussed in #33078 · 1 comment · Fixed by #33122
Assignees
Labels
core:config Related to config capabilities and presets priority-2-high Bugs impacting wide number of users or very important features type:bug Bug fix of existing functionality

Comments

@rarkins
Copy link
Collaborator

rarkins commented Dec 15, 2024

Discussed in #33078

Originally posted by wopian December 13, 2024

How are you running Renovate?

A Mend.io-hosted app

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

No response

Please tell us more about your question or problem

I clicked the checkbox on my dependencies dashboard issue and a PR was created to migrate the config to non-deprecated versions.

The PR created is replacing the entire package.json (metadata, scripts, dependencies) with just the Renovate config hoisted to the top level. Effectively deleting all the package information.

This appears to be malformed behaviour and should be creating a new file (renovate.json?)

Example PR: zeepkist/zeepkist-legacy#1402

Logs (if relevant)

Logs

Replace this text with your logs, between the starting and ending triple backticks

@rarkins rarkins added type:bug Bug fix of existing functionality priority-2-high Bugs impacting wide number of users or very important features core:config Related to config capabilities and presets labels Dec 15, 2024
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 39.69.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core:config Related to config capabilities and presets priority-2-high Bugs impacting wide number of users or very important features type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants