-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replacement for pep440 versioning #17882
fix: replacement for pep440 versioning #17882
Conversation
…g and isReplacement to getNewValue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add any new tests?
Any updates here? @JamieMagee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should prbably also be split into 2 PR's:
- feat: support replacement for pep440
- fix: use correct values for replacements
If you hit this issue with pep440 versioning, do you think might need this for other versioning schemes that support replacement range strategies? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs deconflicting, and potentially a follow-up issue for other versioning schemes, but otherwise looks good to go!
I did not encounter any problems like this with the other managers/datasources I tested, they are listed here in my README. For the pep440 datasource however there is an Error in |
🎉 This PR is included in version 34.24.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
As requested I am splitting my replacement pr #17476.
This pr makes sure the correct
replacementName
andreplacementVersion
are used, as some dependencies didn't get replacements.It also fixes a problem I encountered with pep440, where now the rangeStrategy handling is skipped when the update is a replacement (used to throw an exception and therefore didn't replace the value).