Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replacement support for all managers #17883

Merged

Conversation

t-kulmburg
Copy link
Contributor

As requested I am splitting my replacement pr #17476.
This pr contains the main replacement logic and lots of tests.

@chezsmithy
Copy link
Contributor

I'm so in need of replacement for docker. This feature is a slam dunk to help me solve for a number of deprecated docker images I need teams to swap out. Any ideas on ETA?

@t-kulmburg
Copy link
Contributor Author

Any updates here? @JamieMagee

@viceice viceice changed the title feat: replacement split: auto-replace changes feat: auto-replace for most managers Nov 9, 2022
@viceice viceice changed the title feat: auto-replace for most managers feat: auto-replace for all managers Nov 9, 2022
@viceice viceice changed the title feat: auto-replace for all managers feat: replacement support for all managers Nov 9, 2022
lib/config/utils.ts Outdated Show resolved Hide resolved
@JamieMagee
Copy link
Contributor

Any updates here? @JamieMagee

Apologies. I can find time to sit down and review both PRs in depth this weekend.

Copy link
Contributor

@JamieMagee JamieMagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small comments, but otherwise this looks good. Especially thanks for the extensive test coverage!

JamieMagee
JamieMagee previously approved these changes Nov 14, 2022
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any regression here would have a major impact. How confident is everybody and how widely has this been tested, not only on replacements but on existing autoreplace use cases?

@JamieMagee
Copy link
Contributor

Does merging this PR mean that you can now get replacements for old deprecated dependencies for all package managers? Of course the replacements still need to be programmed into the code for each package.

@HonkingGoose merging this PR will add replacement support for all managers except:

  • bazel
  • git-submodules
  • gomod
  • gradle
  • hermit
  • homebrew
  • maven
  • regex

Co-authored-by: Michael Kriese <[email protected]>
@shoddyknight
Copy link

Very keen on this, currently trying to migrate some internal gitlab-ci.yml, so want to replace

includes:
- project: 'a/b/c'
    ref: 2-2-0

with either

includes:
- project: 'z/x/y'
    ref: 2-2-0

or if needs be can tag new region

includes:
- project: 'z/x/y'
    ref: 2-2-1

docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can prevent the reader confusing the replacementName and replacementVersion sections by saying which "field" they should use.

I'm also rewriting the sentence for extra clarity.

docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
@chezsmithy
Copy link
Contributor

@t-kulmburg @rarkins looks like we might have all the approvals to merge? (I'm so very interested in this feature) 🥇

@t-kulmburg
Copy link
Contributor Author

@rarkins let me know if there is anything more you want me to do here

@rarkins rarkins merged commit 51107e3 into renovatebot:main Jan 11, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.98.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants