-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replacement support for all managers #17883
feat: replacement support for all managers #17883
Conversation
I'm so in need of replacement for docker. This feature is a slam dunk to help me solve for a number of deprecated docker images I need teams to swap out. Any ideas on ETA? |
Any updates here? @JamieMagee |
Apologies. I can find time to sit down and review both PRs in depth this weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small comments, but otherwise this looks good. Especially thanks for the extensive test coverage!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any regression here would have a major impact. How confident is everybody and how widely has this been tested, not only on replacements but on existing autoreplace use cases?
@HonkingGoose merging this PR will add replacement support for all managers except:
|
Co-authored-by: Michael Kriese <[email protected]>
Very keen on this, currently trying to migrate some internal gitlab-ci.yml, so want to replace includes:
- project: 'a/b/c'
ref: 2-2-0 with either includes:
- project: 'z/x/y'
ref: 2-2-0 or if needs be can tag new region includes:
- project: 'z/x/y'
ref: 2-2-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can prevent the reader confusing the replacementName
and replacementVersion
sections by saying which "field" they should use.
I'm also rewriting the sentence for extra clarity.
Co-authored-by: HonkingGoose <[email protected]>
…ce' into feat/replacement-part-auto-replace
# Conflicts: # lib/workers/repository/update/branch/get-updated.spec.ts
@t-kulmburg @rarkins looks like we might have all the approvals to merge? (I'm so very interested in this feature) 🥇 |
@rarkins let me know if there is anything more you want me to do here |
🎉 This PR is included in version 34.98.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
As requested I am splitting my replacement pr #17476.
This pr contains the main replacement logic and lots of tests.