Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(onboarding): improve preset description resolution #21165

Merged
merged 1 commit into from
Mar 26, 2023
Merged

fix(onboarding): improve preset description resolution #21165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/config/presets/__snapshots__/index.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ exports[`config/presets/index resolvePreset migrates automerge in presets 1`] =
"branchPrefix": "renovate/",
"description": [
"Prefix \`renovate/\` to all branch names.",
"If Renovate detects semantic commits, it will use semantic commit type \`fix\` for dependencies and \`chore\` for all others.",
"Use semantic commit type \`fix\` for dependencies and \`chore\` for all others if semantic commits are in use.",
"Require all status checks to pass before any automerging.",
"Pin dependency versions for \`devDependencies\` and retain SemVer ranges for others.",
],
Expand Down
2 changes: 1 addition & 1 deletion lib/config/presets/internal/default.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ export const presets: Record<string, Preset> = {
},
semanticPrefixFixDepsChoreOthers: {
description:
'If Renovate detects semantic commits, it will use semantic commit type `fix` for dependencies and `chore` for all others.',
'Use semantic commit type `fix` for dependencies and `chore` for all others if semantic commits are in use.',
packageRules: [
{
matchPackagePatterns: ['*'],
Expand Down
4 changes: 2 additions & 2 deletions lib/config/presets/internal/group.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ const staticGroups = {
'group:springWs',
'group:symfony',
],
ignoreDeps: [],
ignoreDeps: [], // Hack to improve onboarding PR description
},
resilience4j: {
description: 'Group Java Resilience4j packages.',
Expand Down Expand Up @@ -730,7 +730,7 @@ for (const monorepo of Object.keys(monorepos.presets)) {
config.monorepos = {
description: 'Group known monorepo packages together.',
extends: monorepoNames,
ignoreDeps: [],
ignoreDeps: [], // Hack to improve onboarding PR description
};

export const presets: Record<string, Preset> = config;
3 changes: 2 additions & 1 deletion lib/config/presets/internal/replacements.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
/* eslint sort-keys: ["error", "asc", {"caseSensitive": false, "natural": true}] */
export const presets: Record<string, Preset> = {
all: {
description: 'All replacements.',
description: 'Apply crowd-sourced package replacement rules.',
extends: [
'replacements:apollo-server-to-scoped',
'replacements:babel-eslint-to-eslint-parser',
Expand All @@ -34,6 +34,7 @@ export const presets: Record<string, Preset> = {
'replacements:vsts-task-lib-to-azure-pipelines-task-lib',
'replacements:xmldom-to-scoped',
],
ignoreDeps: [], // Hack to improve onboarding PR description
},
'apollo-server-to-scoped': {
description: '`apollo-server` packages became scoped.',
Expand Down
4 changes: 2 additions & 2 deletions lib/config/presets/internal/workarounds.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import type { Preset } from '../types';
export const presets: Record<string, Preset> = {
all: {
description: [
'A collection of workarounds for known problems with packages.',
'Apply crowd-sourced workarounds for known problems with packages.',
],
extends: [
'workarounds:mavenCommonsAncientVersion',
Expand All @@ -20,7 +20,7 @@ export const presets: Record<string, Preset> = {
'workarounds:disableMavenParentRoot',
'workarounds:containerbase',
],
ignoreDeps: [],
ignoreDeps: [], // Hack to improve onboarding PR description
},
containerbase: {
description: 'Add some containerbase overrides',
Expand Down