Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(yaml): add test for YAML tags #31244

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

websi
Copy link
Contributor

@websi websi commented Sep 6, 2024

Changes

Add generic support for YAML tags.

Context

See #31147

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice self-requested a review September 9, 2024 06:23
@websi
Copy link
Contributor Author

websi commented Sep 13, 2024

@viceice is this needed anymore if #31336 is merged.
Maybe we should also at an testcase for docker-compose yaml tags within #31336.

@rarkins rarkins marked this pull request as draft September 16, 2024 05:07
@websi
Copy link
Contributor Author

websi commented Sep 18, 2024

@rarkins @viceice #31336 seems not to fix this problem.

What is the next step? Should i rebase and adapt the changes?

@viceice
Copy link
Member

viceice commented Sep 18, 2024

@rarkins @viceice #31336 seems not to fix this problem.

What is the next step? Should i rebase and adapt the changes?

you need to adapt the code for the new yaml parser. it should now be possible to support custom yaml tags without removing them.

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see other comment

@websi websi changed the title feat(yaml): add generic support for YAML tags test(yaml): add test for YAML tags Sep 18, 2024
@websi
Copy link
Contributor Author

websi commented Sep 18, 2024

I tested the current master against https://github.com/websi/renovate-reproductions-31147. Everything works with the new library. I add some new test cases for the YAML tags and remove the extra handling for the GitLab Reference tag

@websi websi marked this pull request as ready for review September 18, 2024 12:47
@rarkins rarkins enabled auto-merge October 4, 2024 09:51
@websi websi requested a review from viceice October 4, 2024 10:03
@rarkins rarkins added this pull request to the merge queue Oct 4, 2024
Merged via the queue into renovatebot:main with commit 1aba1ef Oct 4, 2024
38 checks passed
@websi websi deleted the feat/yaml-tags branch October 4, 2024 13:37
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 38.110.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-merge-queue bot pushed a commit to zemn-me/monorepo that referenced this pull request Oct 4, 2024
##### [`v38.110.1](https://github.com/renovatebot/renovate/releases/tag/38.110.1)

##### Bug Fixes

-   **deps:** update ghcr.io/renovatebot/base-image docker tag to v7.34.1 ([#31794](renovatebot/renovate#31794)) ([76311ac](renovatebot/renovate@76311ac))

##### Miscellaneous Chores

-   **deps:** update otel/opentelemetry-collector-contrib docker tag to v0.111.0 ([#31793](renovatebot/renovate#31793)) ([76d5af1](renovatebot/renovate@76d5af1))

##### Continuous Integration

-   don't fetch GitHub issues on merge queue ([#31792](renovatebot/renovate#31792)) ([e4da099](renovatebot/renovate@e4da099))
##### [`v38.110.0](https://github.com/renovatebot/renovate/releases/tag/38.110.0)

##### Features

-   **presets:** Add jackson-module-kotlin repo to jackson monorepo ([#31772](renovatebot/renovate#31772)) ([bb809d3](renovatebot/renovate@bb809d3))

##### Code Refactoring

-   **manager/gitlabci:** remove method "replaceReferenceTags" ([#31787](renovatebot/renovate#31787)) ([354e6f8](renovatebot/renovate@354e6f8))

##### Tests

-   **yaml:** add test for YAML tags ([#31244](renovatebot/renovate#31244)) ([1aba1ef](renovatebot/renovate@1aba1ef))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants